(A) At first, this could be a configuration-file-only feature initially. Basically of only interest for experimentation. Wouldn't this be a quick change? Doesn't RetroArch support undocumented options? (If I am wrong, then yeah, it would be harder).ophidon wrote: ↑18 Sep 2020, 13:51Yes, I am not against the idea at all. I never have an issue with more options existing than I would personally take advantage of. The comma seperated list doesn't exactly match how Retroarch seems to have designed its menu options to be programmed, but you could still easily do a predetermined set of patterns without a major rewrite. It's just I wanted to get this version out first, before considering additions in case life gets too busy soon (which is possible as we have a new puppy arriving soonish, to train).
(B) Or you can synthetically generate your own comma-separated internally simply by "BFI Full Brightnes Frame Count: Number", "BFI Decay Frame Count: Number" (for frames after last full brightness frame) etc. And automatically calculate. Decay speed should be a geometric formula. And use padding (zeros) and trunctation depending on framerate-vs-refreshrate divisor automatically calculated.
Regardless of whether you do approach (A) or (B) or both, you'd process the string into a float/double array, and cycle on that as your BFI sequence -- item (A) should be easy peasy (in theory) with no UI changes? That way, user experimentation on (A) can be done before doing UI changes to add (B), perhaps selectable profiles of discovered beneficial custom BFI sequences. Both can be done above, with a Custom setting to load the manually-edited text line from the configuration file.
This could be a separate pull request, but I would wait on closing BFIv2 github unless sufficient configurability is added since I consider complete BFI sequence mandatory for a closure of BFIv2 (though future iterative enhancements such as moving BFIv2 into a separate thread will prepare it better for conversion to a BFIv3 algorithm)
I'm open with whatever BFIv2 configurability you come up with -- I'm totally happy with hand-edited configuration file initially for experimentation's sake before any official BFI-sequence UI configurability.